Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming: add pep8 / pylint goodness #1210

Merged
merged 17 commits into from
Nov 19, 2015
Merged

Streaming: add pep8 / pylint goodness #1210

merged 17 commits into from
Nov 19, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 29, 2015

Uses #1209 as a base.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2015
@tseaver tseaver mentioned this pull request Oct 29, 2015
Merged
@tseaver tseaver mentioned this pull request Nov 6, 2015
Closed
5 tasks
@tseaver
Copy link
Contributor Author

tseaver commented Nov 19, 2015

@dhermes rebased after merge of #1209.

@dhermes
Copy link
Contributor

dhermes commented Nov 19, 2015

Theres a bit more than PEP8 changes in "Get 'pep8' working on 'gcloud/streaming'." (e.g. dropping request = _Request() and using self.URL in test_transfer.py). No worries though, just an observation, the commit is all good.

dhermes
dhermes reviewed Nov 19, 2015
View reviewed changes
gcloud/streaming/exceptions.py
return int(self.response['status'])

@classmethod
def FromResponse(cls, http_response):
def from_response(cls, http_response):
"""Factory: construct an exception from a resopnse."""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Nov 19, 2015
View reviewed changes
gcloud/streaming/transfer.py
@@ -812,7 +1155,7 @@ def _send_chunk(self, start):
end = body_stream.stream_end_position
if body_stream.stream_exhausted:
self.__total_size = end
# TODO: Here, change body_stream from a stream to a string object,
# Here, change body_stream from a stream to a string object,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Nov 19, 2015

Finished review

@dhermes dhermes mentioned this pull request Nov 19, 2015
Closed
@tseaver tseaver mentioned this pull request Nov 19, 2015
Closed
@dhermes
Copy link
Contributor

dhermes commented Nov 19, 2015

LGTM

tseaver added a commit that referenced this pull request Nov 19, 2015
@tseaver
Merge pull request #1210 from tseaver/streaming-pep8_pylint
46d8253 
Streaming: add pep8 / pylint goodness
@tseaver tseaver merged commit 46d8253 into googleapis:master Nov 19, 2015
@tseaver tseaver deleted the streaming-pep8_pylint branch November 19, 2015 18:00
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot